Skip to content

Harden DisplayReporter against null messages #6920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lrytz merged 1 commit into from
Jul 11, 2018
Merged

Harden DisplayReporter against null messages #6920

lrytz merged 1 commit into from
Jul 11, 2018

Conversation

@retronym
Copy link
Member

@retronym retronym commented Jul 11, 2018

Relates to #6635

@scala-jenkins scala-jenkins added this to the 2.13.0-M5 milestone Jul 11, 2018
@retronym retronym requested a review from som-snytt July 11, 2018 06:24
@som-snytt
Copy link
Contributor

som-snytt commented Jul 11, 2018

That code is also broken, I neglected to get back to it. But you can't beat checking for null.

@som-snytt
Copy link
Contributor

som-snytt commented Jul 11, 2018 •
edited
Loading

In the old days,

scala 2.12.6> import scala.tools.nsc._, reporters._
import scala.tools.nsc._
import reporters._

scala 2.12.6> val r = new ConsoleReporter(new Settings)
r: scala.tools.nsc.reporters.ConsoleReporter = scala.tools.nsc.reporters.ConsoleReporter@78cfa264

scala 2.12.6> r.echo(null)
java.lang.NullPointerException
  at scala.collection.immutable.StringLike$$anon$1.<init>(StringLike.scala:113)
  at scala.collection.immutable.StringLike.linesWithSeparators(StringLike.scala:111)
  at scala.collection.immutable.StringLike.linesWithSeparators$(StringLike.scala:111)
  at scala.collection.immutable.StringOps.linesWithSeparators(StringOps.scala:29)
  at scala.collection.immutable.StringLike.lines(StringLike.scala:130)
  at scala.collection.immutable.StringLike.lines$(StringLike.scala:129)
  at scala.collection.immutable.StringOps.lines(StringOps.scala:29)
  at scala.reflect.internal.util.StringOps.trimAllTrailingSpace(StringOps.scala:48)
  at scala.reflect.internal.util.StringOps.trimAllTrailingSpace$(StringOps.scala:48)
  at scala.reflect.internal.util.StringOps$.trimAllTrailingSpace(StringOps.scala:95)
  at scala.tools.nsc.reporters.ConsoleReporter.echo(ConsoleReporter.scala:48)
  ... 28 elided

I guess String.valueOf never got you in trouble, like buying IBM.

som-snytt
som-snytt approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@som-snytt som-snytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harden thy heart.

@retronym
Copy link
Member Author

retronym commented Jul 11, 2018 •
edited
Loading

We have reporter.error(tree.pos, ex.getMessage()) in a few places which is a source of null messages (fittingly, with NullPointerException#getMessage!)

@lrytz lrytz merged commit fcb196e into scala:2.13.x Jul 11, 2018
@dwijnand dwijnand mentioned this pull request Oct 16, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@som-snytt som-snytt som-snytt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.13.0-M5

Development

Successfully merging this pull request may close these issues.

4 participants

@retronym @som-snytt @lrytz @scala-jenkins