Revert to using ConsoleReporter during spin up #6778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a nice idea to use a minimal reporter until Global is created, but not all clients (benchmark) create a fresh reporter with their Global, choosing to stick with the default provided by Driver. Also move reporter creation to `Reporter.apply`.
retronym
approved these changes
Jun 12, 2018
Member
retronym
left a comment
retronym
left a comment
There was a problem hiding this comment.
Thanks for the fix and for the test.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a nice idea to use a minimal reporter until
Global is created, but not all clients (benchmark)
create a fresh reporter with their Global,
choosing to stick with the default provided
by Driver.
Also move reporter creation to
Reporter.apply.This is a follow-up to #6635 (comment)