Add a flatten operation to Either #6681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuwei-k
reviewed
May 29, 2018
src/library/scala/util/Either.scala
Outdated
| * | ||
| * Equivalent to `flatMap(id => id)` | ||
| */ | ||
| def flatten[A1 >: A, B1](implicit ev: B <:< Either[A1, B1]): Either[A1, B1] = flatMap(b => ev(b)) |
Contributor
There was a problem hiding this comment.
flatMap(ev) instead of flatMap(b => ev(b)) ?
(<:< extends scala.Function1 https://github.com/scala/scala/blob/v2.13.0-M4/src/library/scala/Predef.scala#L532 )
martijnhoekstra
force-pushed
the
flatteneither
branch
from
f38b734 to
2877496
Compare
lrytz
approved these changes
May 30, 2018
jozic
reviewed
May 30, 2018
|
|
||
|
|
||
| /** Returns the right value if this is right | ||
| * or this value if this if this is left |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#10910