Faster implicit search: lazier error messages #6612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't eagerly compute unseen, yet expensive error messages (because we're in a nested search, or -Xlog-implicits is not enabled).
lrytz
approved these changes
May 10, 2018
SethTisue
added
the
performance
Contributor
|
It turns out that specs2-scalaz has been relying on side-effects in As discussed on the 2.12.x backport PR (#6582 (comment)) this has already been worked around (/cc @etorreborre) in the specs2 updates for 2.13.0-M4, so there might be nothing more to do now, but flagging up here just in case. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply takes the part of #6580 that is ready right now for M4 (which is due on Monday). Perhaps the more subtle improvements will be ready too by then, but I wanted to make sure we book this win. Nice find, @milessabin and @smarter!
Don't eagerly compute unseen, yet expensive error messages
(because we're in a nested search, or -Xlog-implicits is not enabled).