Make dropWhile in Stream and LazyList stack-safe #6608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm happy to add to this PR with more overridden methods; I'm just not sure exactly which methods are needed atm |
NthPortal
force-pushed
the
topic/lazylist-stack-safety/PR
branch
from
9613f0b to
9250f0c
Compare
NthPortal
commented
May 9, 2018
| object Test extends App { | ||
| // Should not overflow the stack | ||
| Iterator.iterate(LazyList.from(0))(_.dropWhile(_ => false)).drop(10000).next | ||
| Iterator.iterate( Stream.from(0))(_.dropWhile(_ => false)).drop(10000).next |
Contributor
Author
There was a problem hiding this comment.
doesn't check for stack safety well enough - need to ensure that head and tail get evaluated (for both LazyList and Stream)
Contributor
Author
There was a problem hiding this comment.
Although the actual problem Seth mentioned doesn't seem to manifest with LazyList anyway, it's good to check that it works
NthPortal
force-pushed
the
topic/lazylist-stack-safety/PR
branch
from
9250f0c to
17f77f1
Compare
|
@NthPortal I wonder if it's a valid test to check if a they use memory sharing. |
Contributor
Author
|
@javax-swing while they should do that, that feels to me like specifying an internal behaviour for no reason; maybe that's just me though |
Override `dropWhile` in `LinearSeqOps`. Remove redundant override for `dropWhile` in `List`.
NthPortal
force-pushed
the
topic/lazylist-stack-safety/PR
branch
from
17f77f1 to
1bbef85
Compare
Contributor
Author
|
ping @SethTisue |
lrytz
approved these changes
Jun 1, 2018
Member
|
Thanks, @NthPortal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses at least part of @SethTisue's concern in scala/collection-strawman#197.