Skip to content

Conversation

@eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented May 2, 2018

This deprecates package objects with inheritance, and removes it under -Xsource:2.14.

Ref scala/scala-dev#488
Ref scala/scala-dev#441

This deprecates package objects with inheritance, and removes it under -Xsource:2.14.

Ref scala/scala-dev#488
Ref scala/scala-dev#441
@eed3si9n eed3si9n force-pushed the wip/deprecate-package-inheritance branch from 4ec5b3f to e9ba65f Compare May 2, 2018 16:11
@xeno-by
Copy link
Contributor

xeno-by commented May 2, 2018

Is this a nomerge kind of an experiment to check whether the build is going to be green, or there is an intention to merge these changes into master? If it's the latter, I think we need a SIP and an approval from the SIP commitee first.

@eed3si9n
Copy link
Member Author

eed3si9n commented May 2, 2018

Is this a nomerge kind of an experiment to check whether the build is going to be green, or there is an intention to merge these changes into master? If it's the latter, I think we need a SIP and an approval from the SIP commitee first.

I came across an issue "Deprecate inheritance for package objects" that was created recently so I implemented it (as civilian in my off hours) assuming it was decided good to go in some SIP meeting.

If there hasn't been a consensus on this, I'll be happy to mark this dont-merge. To avoid divergence of discussion, could you also comment on scala/scala-dev#441 there as well please?

@eed3si9n eed3si9n changed the title Deprecate package objects with inheritance (Do not merge) Deprecate package objects with inheritance May 2, 2018
@adriaanm adriaanm added the WIP label Jun 12, 2018
@adriaanm
Copy link
Contributor

adriaanm commented Aug 3, 2018

Since this will take a while, I'm going to schedule this for after 2.13.0

@adriaanm adriaanm modified the milestones: 2.13.0-M5, 2.13.x Aug 3, 2018
@adriaanm
Copy link
Contributor

adriaanm commented Aug 3, 2018

(As our policy allows deprecations in a minor release.)

@SethTisue
Copy link
Member

closing for now to get it out of the open PR queue. the scala-dev ticket is on the 2.13.1 milestone, so we won't lose track of it

@SethTisue SethTisue closed this Nov 6, 2018
@SethTisue SethTisue removed this from the 2.13.1 milestone Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants