Deprecate floating-point Ranges #6550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref scala/bug#10781 This is in preparation for Float range and Double range removal in 2.13.x (scala#6468).
Member
|
@lrytz you want to get this into 2.12.6? I'm ambivalent. |
Member
|
If we're going to merge scala/bug#10781, then I'm in favor of shipping the deprecation with 2.12.6. |
Contributor
|
I am in favor since these things are fragile and should not be used. Innocuous-seeming changes can convert a "working" floating-point range into one with a (mathematical) off-by-one error. |
SethTisue
changed the title
SethTisue
changed the title
SethTisue
changed the title
xuwei-k
added a commit
to xuwei-k/scalatra
that referenced
this pull request
May 14, 2018
scala/scala#6550 ``` Welcome to Scala 2.12.6 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_172). Type in expressions for evaluation. Or try :help. scala> Range.Double.inclusive(0, 1, 0.1) <console>:12: warning: method inclusive in object Double is deprecated (since 2.12.6): use Range.BigDecimal.inclusive instead Range.Double.inclusive(0, 1, 0.1) ^ res0: scala.collection.immutable.NumericRange[Double] = NumericRange 0.0 to 1.0 by 0.1 (using NumericRange 0.0 to 1.0 by 0.1 of BigDecimal) scala> res0.toList res1: List[Double] = List(0.0, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1.0) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref scala/bug#10781
This is in preparation for Float range and Double range removal in 2.13.x (#6468).