Merge 2.12.x to 2.13.x [ci: last-only]#6451
Merged
lrytz merged 17 commits intoscala:2.13.xfrom Mar 21, 2018
Merged
Conversation
- Explicitly add test output path to the compiler classpath Rather than assuming its in the application classpath. - Ensure tests cleanup threads - Fork tests that inherently require it or ones that I can't figure out how to make work without it
Tests that take 30+ seconds to compile and/or execute really add up to a productivity loss for contributors. These tests served a purpose to show that the corresponding changes were correct. But if we want them to serve an ongoing purpose of guarding against regressions, they need to be maintained to do so more quicky or be moved into a test suite that is run less frequently.
…ction The logic that decides to print `Function`, rather than `scala.Function` did not account for the multiplicity of symbols for a given package in the JavaMirrors universe.
…replaced or mutated
- Update to partest that emits more detailed TestEvents - Group partest JUnit XML reports in, e.g, test.files.pos.xml - workaround Jenkins dislike of the work "run" Requires a new version of partest to provide some missing metadata. Sample files generated: ``` > ;partest --srcpath scaladoc --grep t7876; partest --grep default ... ``` ``` ⚡ (cd target/test/test-reports/partest && find . ) . ./test.files.jvm.xml ./test.files.neg.xml ./test.files.pos.xml ./test.files.presentation.xml ./test.files.run_.xml ./test.files.scalap.xml ./test.files.specialized.xml ./test.scaladoc.run_.xml ```
Integrating Scalacheck into our SBT build is all frying pans and fires. We disabled forking to get test failure reporting working, but didn't realise that this put STARR on the classpath of the tests. This commits switches back to forking, but only after customizing the framework to get early access to what hopefully will be part of the next scalacheck release: typelevel/scalacheck#388
Avoid using STARR on the scalacheck classpath
Speed up partest
retronym
changed the title
Merged
lrytz
approved these changes
Mar 21, 2018
Contributor
|
Awesome stuff! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partest speedups the motivation.