Skip to content

update MiMa whitelist for infix annotation #5712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lrytz merged 1 commit into from
Feb 17, 2017
Merged

update MiMa whitelist for infix annotation #5712

lrytz merged 1 commit into from
Feb 17, 2017

Conversation

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 17, 2017 •
edited
Loading

little missing piece of #5589

@scala-jenkins scala-jenkins added this to the 2.12.2 milestone Feb 17, 2017
@SethTisue
Copy link
Member Author

SethTisue commented Feb 17, 2017 •
edited
Loading

fixes the failure seen at e.g. https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-bootstrap/806/consoleFull

it also made one of my own PRs fail validation, which leaves me even more puzzled why this wasn't caught during 5589's own validation oh wait, this was already covered at #5589 (comment). so this is expected, it's because 5589 wasn't rebased before merge

@SethTisue SethTisue mentioned this pull request Feb 17, 2017
Merged
@SethTisue
Copy link
Member Author

SethTisue commented Feb 17, 2017 

Internal error when running tests: sbt.ForkMain$Run$RunAborted: java.net.SocketException: Broken pipe (Write failed)
[error] Error: Total 0, Failed 0, Errors 0, Passed 0
[error] Error during tests:
[error] 	Forked test harness failed: java.lang.NullPointerException
[error] 	at sbt.TestEvent$$anonfun$overallResult$1.apply(TestReportListener.scala:72)
[error] 	at sbt.TestEvent$$anonfun$overallResult$1.apply(TestReportListener.scala:71)
[error] 	at scala.collection.IndexedSeqOptimized$class.foldl(IndexedSeqOptimized.scala:51)
[error] 	at scala.collection.IndexedSeqOptimized$class.foldLeft(IndexedSeqOptimized.scala:60)
[error] 	at scala.collection.mutable.WrappedArray.foldLeft(WrappedArray.scala:34)
[error] 	at scala.collection.TraversableOnce$class./:(TraversableOnce.scala:138)
[error] 	at scala.collection.AbstractTraversable./:(Traversable.scala:105)
[error] 	at sbt.TestEvent$.overallResult(TestReportListener.scala:71)
[error] 	at sbt.TestEvent$$anon$1.<init>(TestReportListener.scala:66)
[error] 	at sbt.TestEvent$.apply(TestReportListener.scala:65)
[error] 	at sbt.React.react(ForkTests.scala:137)
[error] 	at sbt.ForkTests$$anonfun$mainTestTask$1$Acceptor$2$.run(ForkTests.scala:76)
[error] 	at java.lang.Thread.run(Thread.java:745)

@SethTisue
Copy link
Member Author

SethTisue commented Feb 17, 2017

/rebuild

@lrytz
Copy link
Member

lrytz commented Feb 17, 2017

LGTM

@lrytz lrytz merged commit d5aad25 into scala:2.12.x Feb 17, 2017
@lrytz lrytz mentioned this pull request Feb 17, 2017
Merged
@SethTisue SethTisue deleted the mima-fixup branch February 17, 2017 14:12
@SethTisue SethTisue mentioned this pull request Feb 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.12.2

Development

Successfully merging this pull request may close these issues.

3 participants

@SethTisue @lrytz @scala-jenkins