don't deprecate Either.left and Either.right yet #5433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for two reasons: * to facilitate warning-free cross-compilation between Scala 2.11 and 2.12 * because it's not clear that .swap is a good replacement for .left Either.right seems almost certain to be deprecated in 2.13. Either.left's future is uncertain; see discussion (and links to additional discussions) at scala#5135
szeiger
approved these changes
Sep 29, 2016
Contributor
szeiger
left a comment
szeiger
left a comment
There was a problem hiding this comment.
I don't agree with the premise that source compatibility between two releases implies being able to build without warnings on both, but I'm in no hurry to deprecate these methods.
Member
Author
noted. in the general case, I agree. |
Contributor
|
LGTM |
Contributor
|
I'm going to ignore the spurious test failures and merge this. |
Member
Author
|
/nothingtoseehere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #5135
review by @szeiger, @Ichoran, @soc, community. (this will likely be
merged rapidly, but that doesn't mean additional changes, e.g. to the
Scaladoc, can't follow)