Skip to content

SI-9691 BufferedIterator should expose a headOption #5287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szeiger merged 1 commit into from
Jul 18, 2016
Merged

SI-9691 BufferedIterator should expose a headOption #5287

szeiger merged 1 commit into from
Jul 18, 2016

Conversation

@ChristopherDavenport
Copy link
Contributor

@ChristopherDavenport ChristopherDavenport commented Jul 15, 2016

This exposes a new API to the BufferedIterator trait. It will return the next element of an iterator as an Option. The return will be Some(value) if there is a next value, and None if there is not a next element.

This has been squashed and documentation put in place. Was previously covered by #5277

@ChristopherDavenport
SI-9691 BufferedIterator should expose a headOption
11688eb 
This exposes a new API to the BufferedIterator trait. It will return the next element of an iterator as an Option.  The return will be  Some(value) if there is a next value, and None if there is not a next element.
@szeiger
Copy link
Contributor

szeiger commented Jul 18, 2016

LGTM. Congratulations to your first merged PR!

@szeiger szeiger merged commit fbdbfbe into scala:2.12.x Jul 18, 2016
@ChristopherDavenport ChristopherDavenport deleted the ticket/9691-2 branch July 18, 2016 13:04
@pathikrit
Copy link
Contributor

pathikrit commented Jul 19, 2016

👍

@adriaanm adriaanm added the welcome hello new contributor! label Jul 19, 2016
@adriaanm adriaanm modified the milestone: 2.12.0-RC1 Jul 21, 2016
@adriaanm
Copy link
Contributor

adriaanm commented Jul 21, 2016 •
edited
Loading

Btw, this broke slick: https://github.com/slick/slick/blob/master/slick/src/main/scala/slick/util/ReadAheadIterator.scala#L26 (and thus the community build: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/456/consoleFull)

@adriaanm adriaanm mentioned this pull request Jul 21, 2016
Merged
7 tasks
@szeiger
Copy link
Contributor

szeiger commented Jul 21, 2016

How ironic, but we don't really have any way to avoid this sort of problem. The only solution I can think of that allows cross-building Slick is to make ReadAheadIterator.headOption an extension method.

@szeiger szeiger mentioned this pull request Jul 21, 2016
Closed
@adriaanm adriaanm mentioned this pull request Aug 9, 2016
Closed
@adriaanm adriaanm added the 2.12 label Oct 29, 2016
@scabug scabug mentioned this pull request Apr 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

welcome hello new contributor!

Projects

None yet

Milestone

2.12.0-RC1

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristopherDavenport @szeiger @pathikrit @adriaanm @scala-jenkins