Temporarily insource Scalacheck #5229
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Review by @szeiger |
This avoids a linkage error when SBT reflectively calls a TestFramework implementation compiled by quick, as will be the case in the following commit that brings the ScalaCheck sources into the `partest-extras` project.
This is a temporary measure until we release Scala 2.12.0. It means we are able to release milestones, and RCs of Scala without needing a public release of Scalacheck. While we've never had to wait very long for these in the past (Thanks, Rickard!) we'd like to spare the maintainer some work betwen now and 2.12.0. After we release Scala 2.12.0, we'll revert to a binary dependency on the standard Scalacheck.
retronym
force-pushed
the
topic/insource-scalacheck
branch
from
7016c70 to
25af8a8
Compare
Contributor
|
Should we merge #5190 first (it only needs a final approval, everything is ready) and port it to 2.12.x? This would avoid conflicts in build.sbt and make CI run with sbt (since the ant build is not being updated here). Is sbt sufficient anyway? |
Member
Author
|
@szeiger Yes, let's merge the SBT changes first, then merge to 2.12.x, then rebase this PR. I'll also add Ant changes. |
Contributor
adriaanm
added a commit
to scala/scala-partest
that referenced
this pull request
Jun 28, 2016
It was insourced by scala/scala#5229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary measure until we release Scala
2.12.0. It means we are able to release milestones,
and RCs of Scala without needing a public release of
Scalacheck.
After we release Scala 2.12.0, we'll revert to a binary
dependency on the standard Scalacheck.
This uncovered an existing bug in our SBT build related to
STARR being favoured on the classpath when performing test
discovery. This has be worked around by customizing the
testLoadersetting.