SI-9560 Remove dependency on parser-combinators/json #4851
Conversation
|
@SethTisue Could you have a look regarding the build/ant/pom details? |
There was a problem hiding this comment.
Can we drop the gratuitous string interpolation for vector.map(format).mkString("[", ", ", "]")?
|
@Ichoran Thanks for the feedback! |
|
@SethTisue I diffed a smaller example of my own with all kinds of special characters, would be surprised if there were any differences considering the code is pretty much the same as before. |
|
I verified that |
|
@SethTisue @szeiger What's the current status of the ant -> sbt migration? |
|
Now that #4941 has been merged, I think an updated version on top of 2.12.x could be safely merged. The basics of the sbt build should be stable enough not to complicate merges too much in the future. Some tests and integration scripts still need to be ported to sbt (@SethTisue is working on this at the moment), so you'd still need to update both the sbt and the ant build. |
I'm actively working on it. No fundamental obstacles remain afawk, just a parade of details to sort out. The umbrella ticket to watch is scala/scala-dev#45. |
|
Sorry for the ping ... is there an estimated timeframe when the SBT build will be switched on, or promoted as the main way to build scala/scala? |
|
We hope to have this done in the next two weeks. |
|
@soc there's no reason to hold this change back, even if we're still using the ant build on CI. could you rebase the patch? |
| Export-Package: *;version=${ver} | ||
| Import-Package: jline.*;resolution:=optional, \ | ||
| org.apache.tools.ant.*;resolution:=optional, \ | ||
| scala.util.parsing.*;version="${range;[====,====];@PARSER_COMBINATORS_VERSION@}";resolution:=optional, \ |
There was a problem hiding this comment.
There's a similar import spec in build.sbt that needs to be changed. This file is only used by ant.
|
Flushing the M5 queue on Monday. Please update until then if you want this to go into 2.12.0 (but this looks safe to put into a non-.0 release as well) |
Also update a few example IDE files for Eclipse and IntelliJ. This drops the dependency by integrating the bare minimum functionality to keep things working.
|
@szeiger Updated! Could you have a look? |
|
LGTM |
|
thanks, Simon! really nice to have this resolved |
8 participants
This drops the dependency by integrating the bare minimum functionality
to keep things working.