Reflective compiler now crashes properly #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust toolbox to escalate errors reported during reflective compilation.
Without this functionality, errors get swallowed and lead to weirdness
like https://issues.scala-lang.org/browse/SI-5274. The only meaningful
part of the output in the bug report linked above is the first line.
Subsequent stack trace is at best useless and at worst misleading.
Now the error report is much more sane: https://gist.github.com/1443232
Review by @odersky.