SI-8314 Prevent SI-8314 by adding a test #3899
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SI-8589 Performance improvement for ArrayCharSequence.toString
test/scaladoc/run/t8314.scala
Outdated
Contributor
There was a problem hiding this comment.
Or root._class("A").comment foreach println.
So it could run under -Ywarn-value-discard. If it had to. Maybe easier to read, etc. Half-point reduction for each paren, full points for braces and underscores.
I just made up that scoring system. Or underscoring system.
Contributor
|
What a nifty test. I tested it on 2.10 and 2.11. Maybe the test should be committed to 2.10.x and merged up. Especially relevant if it is subject to regression. |
Contributor
Author
|
Did you mean that rebase this branch against 2.10.x? |
Contributor
|
@kzys 2.10.x is regularly merged into 2.11.x, and 2.11.x into 2.12.x; so by rebasing and submitting the PR to 2.10.x, your test will end up in all versions (this is easier than backporting). |
The original issue was fixed already. This test is just for make sure.
Contributor
Author
|
Thanks. Please review #3904. |
hrhino
added a commit
to hrhino/scala
that referenced
this pull request
Jan 1, 2020
I nearly resolved to clear the scala/bug backlog this year. Fixes scala/bug#3899 Fixes scala/bug#7686 Fixes scala/bug#9668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue was fixed already. This test is just for make sure.