Skip to content

CI: add JDK 26 to mergely matrix#11234

Closed
SethTisue wants to merge 2 commits intoscala:2.12.xfrom
SethTisue:jdk-26-mergely-ci
Closed

CI: add JDK 26 to mergely matrix#11234
SethTisue wants to merge 2 commits intoscala:2.12.xfrom
SethTisue:jdk-26-mergely-ci

Conversation

@SethTisue
Copy link
Copy Markdown
Member

includes an extra commit, to be dropped before merge, that will make it run during PR validation, too

@scala-jenkins scala-jenkins added this to the 2.12.22 milestone Apr 1, 2026
@SethTisue SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Apr 1, 2026
@SethTisue SethTisue self-assigned this Apr 1, 2026
@SethTisue
Copy link
Copy Markdown
Member Author

ahh,

[error] /home/runner/work/scala/scala/src/library/scala/math/Ordering.scala:106:7: name clash between defined and inherited member:
[error] <defaultmethod> def max[U <: T](x$1: U,x$2: U): U in trait Comparator and
[error] def max(x: T,y: T): T at line 106
[error] have same type after erasure: (x$1: Object, x$2: Object)Object
[error]   def max(x: T, y: T): T = if (gteq(x, y)) x else y
[error]       ^
[error] /home/runner/work/scala/scala/src/library/scala/math/Ordering.scala:109:7: name clash between defined and inherited member:
[error] <defaultmethod> def min[U <: T](x$1: U,x$2: U): U in trait Comparator and
[error] def min(x: T,y: T): T at line 109
[error] have same type after erasure: (x$1: Object, x$2: Object)Object
[error]   def min(x: T, y: T): T = if (lteq(x, y)) x else y
[error]       ^
[error] /home/runner/work/scala/scala/src/library/scala/math/Ordering.scala:178:18: name clash between defined and inherited member:
[error] <defaultmethod> def max[U <: T](x$1: U,x$2: U): U in trait Comparator and
[error] override def max(x: T,y: T): T at line 178
[error] have same type after erasure: (x$1: Object, x$2: Object)Object
[error]     override def max(x: T, y: T): T = outer.min(x, y)
[error]                  ^
[error] /home/runner/work/scala/scala/src/library/scala/math/Ordering.scala:179:18: name clash between defined and inherited member:
[error] <defaultmethod> def min[U <: T](x$1: U,x$2: U): U in trait Comparator and
[error] override def min(x: T,y: T): T at line 179
[error] have same type after erasure: (x$1: Object, x$2: Object)Object
[error]     override def min(x: T, y: T): T = outer.max(x, y)
[error]                  ^

this is anticipated, as per discussion on #11175

I'm going to close this and target 2.13.x instead. as for whether to backport to 2.12.x, I leave that up to Lukas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal not resulting in user-visible changes (build changes, tests, internal cleanups)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants