Revert "[backport] Tweak variance of Ordering.min and .max"#11186
Merged
lrytz merged 1 commit intoscala:2.12.xfrom Nov 25, 2025
Merged
Revert "[backport] Tweak variance of Ordering.min and .max"#11186lrytz merged 1 commit intoscala:2.12.xfrom
lrytz merged 1 commit intoscala:2.12.xfrom
Conversation
This reverts commit 516ea32. We decided to keep the current signature for Ordering.min / .max in 2.12.21, and change it only when Java 26 is actually released. See discussion on PR 11175.
lrytz
force-pushed
the
revert-ordering
branch
from
41dd050 to
1ddafac
Compare
SethTisue
added
the
library:base
lrytz
added a commit
to scala/community-build
that referenced
this pull request
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 516ea32.
We decided to keep the current signature for Ordering.min / .max in 2.12.21, and change it only when Java 26 is actually released.
See discussion on PR 11175.