Re-introduce null checks to ScalaRunTime.wrapXArray#11165
Merged
lrytz merged 1 commit intoscala:2.13.xfrom Oct 27, 2025
Merged
Conversation
Member
Author
|
(it's "null check", not "Milkshake") |
sjrd
approved these changes
Oct 27, 2025
som-snytt
reviewed
Oct 27, 2025
When using an array as sequence argument in Scala 3, the compiler emits a conversion to a `Seq` using `ScalaRunTime.wrapXArray`. The change in PR 11021 affects the semantics of such code.
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Dec 9, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `Scala` to `2.13.18`. ### Why are the changes needed? To bring the latest bug fixed version. - https://github.com/scala/scala/releases/tag/v2.13.18 - Fixes for false positive warnings - scala/scala#11165 for Scala 3 - scala/scala#11175 - scala/scala#11172 ### Does this PR introduce _any_ user-facing change? Yes, this is a user-facing Scala version change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53396 from dongjoon-hyun/SPARK-54645. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an array as sequence argument in Scala 3, the compiler emits a conversion to a
SequsingScalaRunTime.wrapXArray. The change in PR 11021 affects the semantics of such code.Reverts #11021
Ref scala/scala3#24204