Skip to content

Fix ArrayBuilder regression in Scala 2.13.13 (OutOfMemoryError when adding empty arrays) #10722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
som-snytt merged 1 commit into from
Apr 8, 2024
Merged

Fix ArrayBuilder regression in Scala 2.13.13 (OutOfMemoryError when adding empty arrays) #10722

som-snytt merged 1 commit into from
Apr 8, 2024

Conversation

@som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Mar 21, 2024 •
edited by SethTisue
Loading

Defer array resize on empty; resizeUp no longer resizes at target length zero.

addAll no longer assumes elems is allocated (non-null).

ArrayBuffer allocates eagerly anyway, so it is unaffected by not resizing at "default".

Fixes scala/bug#12971

@scala-jenkins scala-jenkins added this to the 2.13.15 milestone Mar 21, 2024
@som-snytt som-snytt modified the milestones: 2.13.15, 2.13.14 Mar 21, 2024
@SethTisue SethTisue added prio:blocker release blocker (used only by core team, only near release time) library:collections PRs involving changes to the standard collection library labels Mar 21, 2024
@SethTisue SethTisue requested a review from a team March 21, 2024 18:58
OndrejSpanel
OndrejSpanel reviewed Mar 21, 2024
View reviewed changes
@He-Pin He-Pin mentioned this pull request Mar 22, 2024
Merged
He-Pin
He-Pin reviewed Mar 22, 2024
View reviewed changes
OndrejSpanel
OndrejSpanel reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@OndrejSpanel OndrejSpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the more logical order would be to test for

lrytz
lrytz approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@som-snytt som-snytt force-pushed the issue/12971-array-builder branch from 46eda07 to 6671b71 Compare April 4, 2024 17:26
@som-snytt som-snytt merged commit fd3e629 into scala:2.13.x Apr 8, 2024
@som-snytt som-snytt deleted the issue/12971-array-builder branch April 8, 2024 17:18
@SethTisue SethTisue added release-notes worth highlighting in next release notes and removed prio:blocker release blocker (used only by core team, only near release time) labels Apr 8, 2024
@SethTisue SethTisue changed the title Defer array resize on empty Defer array resize on empty (fixing 2.13.13 regression) Apr 19, 2024
@SethTisue SethTisue changed the title Defer array resize on empty (fixing 2.13.13 regression) Fix ArrayBuilder regression in Scala 2.13.13 (OutOfMemoryError when adding empty arrays) Apr 19, 2024
@LuciferYang LuciferYang mentioned this pull request May 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lrytz lrytz lrytz approved these changes

+2 more reviewers

@He-Pin He-Pin He-Pin left review comments

@OndrejSpanel OndrejSpanel OndrejSpanel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

library:collections PRs involving changes to the standard collection library release-notes worth highlighting in next release notes

Projects

None yet

Milestone

2.13.14

Development

Successfully merging this pull request may close these issues.

ArrayBuilder regression in scala 2.13.13, OutOfMemoryError when adding empty arrays

6 participants

@som-snytt @lrytz @He-Pin @OndrejSpanel @SethTisue @scala-jenkins