-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Remove SHELLOPTS=vi and -Xjline support; reinstate -Xnojline
#10716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@lrytz @som-snytt wdyt? I've tentatively milestoned it for 2.13.14. if there is past history around this particular piece of code, I don't remember it. It came in in the big 2.13.12 JLine PR by Som (#8036) |
|
@ckipp01 are you a good person to ask about the vi side of this...? |
meh, not really as I really don't use the REPL often. The reasoning here seems to make sense though. |
|
I'm agnostic on drudgery of "run it again with this other option"... I see that works and is the reason I haven't had vi bindings in a while. My "to do" list from Feb 20 says "learn more about using jline more effectively." Oh, that was Feb 20, 2016. Edit: there is a PR about "where to put REPL files" and previous ticket(s) about "provide .rc or .inputrc support". It would be more of a clear win if there were a "private" .inputrc in the REPL-specific directory. Without knowing much about it, I'm wary of the global config problem. Edit: I see the linked PR (which was finally merged at pandemic lockdown) links to the .inputrc support which was merged a year later. So maybe indeed just remove all the options. |
|
Good catch on the -Xjline. I'll review how it has been implemented. I would remove even that since there is no point in having scala-specific way of configuring JLine. Using the I think the input mode should be personal and thus there is no reason to make it project-specific. It should be user specific and thus |
|
While we could return back the Note that If @som-snytt you think that the |
This functionality is better provided by jline through the `~/.inputrc` or other file pointed to by `-Djline.inputrc` The content of the file needs to just include the line ``` set editing-mode vi # or emacs ```
|
Pushed a new version with |
som-snytt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on assumption that using standard underlying mechanism is preferable.
SHELLOPTS=vi and -Xjline support; reinstate -Xnojline
This functionality is better provided by jline through the
~/.inputrcor other file pointed to by-Djline.inputrcThe content of the file needs to just include the line
The current implementation doesn't check whether the terminal can support
vioremacsmodes, and hence it causes problems to, for example, emacs users running the REPL in comint buffer