Improve symbol in implicit result check [ci: last-only] #10706
Conversation
som-snytt
force-pushed
the
issue/12967-msg
branch
from
36c7086 to
fd860a2
Compare
|
The failure confused me because at midnight I enabled linting and thought I got rid of that "arg parser" on that PR. Actually, the error started on this PR, not because I enabled linting but because I fixed the "recursive implicit" lint (accidentally or incidentally). Anyway, I wound up ripping out the old "CLI spec" experiment from partest, where it had been sequestered. LOC are just a maintenance cost if they don't pull their weight. |
som-snytt
changed the title
| */ | ||
| implicit val IntFromString: FromString[Int] = new FromString[Int] { | ||
| override def isDefinedAt(s: String) = s.toIntOption.isDefined | ||
| def apply(s: String) = s.toInt |
There was a problem hiding this comment.
| def apply(s: String) = s.toInt | |
| def apply(s: String) = Integer.parseInt(s) |
Agree about LOC weight and such, but the lint is right - why not fix the code? It's a great example where the lint actually helps
scala> implicit val s2i: String => Int = x => x.toInt
^
warning: Implicit resolves to enclosing value s2i
val s2i: String => Int = $Lambda/0x0000000800644a40@446e7065
scala> "3": Int
val $line3$read: $line3.$read.INSTANCE.type = $line3.$read.INSTANCE; import $line3$read.$iw.`s2i`
^
<synthetic>:2: warning: Unused import
(To diagnose errors in synthetic code, try adding `// show` to the end of your input.)
java.lang.StackOverflowError
at $anonfun$s2i$1(<console>:1)
at $anonfun$s2i$1$adapted(<console>:1)There was a problem hiding this comment.
OK here I'll restore it to its previous correct version, then rip it out in the other PR.
partest does no arg converting, is why it didn't matter.
edit: I didn't quite revert the LOC.
som-snytt
force-pushed
the
issue/12967-msg
branch
from
2953635 to
3015a04
Compare
3 participants
Fixes scala/bug#12967