Optimize tail recursion on effectively final methods even when final keyword is absent
#10629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
reviewed
Dec 13, 2023
lrytz
approved these changes
Dec 13, 2023
lrytz
force-pushed
the
issue/9414-known-subclasses
branch
from
ea341fa to
8df9830
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
@som-snytt Does Scala 3 already do this same thing? |
Contributor
Author
|
I believe I tried it and no. Footnote there are also Scala 3 tailrec behaviors to backport IIRC. |
SethTisue
changed the title
final keyword is absent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infer finality by consulting sealed/local hierarchy for overrides.
This permits more tailrec in the absence of final.
Fixes scala/bug#9414
Pursues the retronym branch.