SIP-NN - Converters among optional Functions, PartialFunctions and extractor objects #1135
Conversation
|
I don't understand why the build fails in CI. Anyone can help? |
|
Yes, not related to your PR I think, but related to the tut upgrade we did, I've created a PR #1136 |
jvican
left a comment
jvican
left a comment
There was a problem hiding this comment.
This proposal makes sense to me and I don't see any obvious problem with it. I'm happy you did this @Atry. I just left one comment to improve the proposal. It may be worth noting that this is not a compiler-related change, but a library-related change, in a more succinct way.
|
|
||
| ## Drawbacks | ||
|
|
||
| Why should we *not* do this. Be honest, these questions will come out during the |
There was a problem hiding this comment.
I don't understand this section. Is this some kind of note for yourself? If not, can you clarify what you mean by this and list the drawbacks that you see from your side?
There was a problem hiding this comment.
It's a placeholder section copied from the SIP template. I just deleted the section now.
…s-and-extractor-objects.md
jvican
left a comment
jvican
left a comment
There was a problem hiding this comment.
I like the new cheat sheet you just added. Thanks for removing that section. LGTM.
|
This SIP is not found in https://docs.scala-lang.org/sips/all.html. Is it the intended behavior? |
|
Note, scala/scala#7111 indicates that this SIP may need to be skipped |
4 participants
Discussed at https://contributors.scala-lang.org/t/converters-between-a-option-b-partialfunction-and-extractor-objects/287