-
Notifications
You must be signed in to change notification settings - Fork 28
Add settings allowing AOSP style #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
plugin/src/main/scala/com/lightbend/sbt/javaformatter/JavaFormatter.scala
Outdated
Show resolved
Hide resolved
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
plugin/src/main/scala/com/lightbend/sbt/JavaFormatterPlugin.scala
Outdated
Show resolved
Hide resolved
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
1 similar comment
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
|
I'll fix the "typesafe-cla-validator" issue with next commit |
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
1 similar comment
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
|
@nigredo-tori Hi, new changes :) |
|
@joriscode, LGTM 👍 |
14c039c to
9f9a628
Compare
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
9f9a628 to
8575ce2
Compare
|
@nigredo-tori CLA fixed and history rebased & squashed. Thank you for the reviews. PR is now ready for merge |
pvlugter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
|
And released as version |
This PR adds opt-in setting for the AOSP style supported by https://github.com/google/google-java-format/blob/master/core/src/main/java/com/google/googlejavaformat/java/JavaFormatterOptions.java.
Please let me know what you think