Skip to content

Conversation

@alejandrohdezma
Copy link
Contributor

This method is being used in sbt-github and the build is broken when updating to sbt-header v5.8.0.

@hseeberger
Copy link
Member

Hey @vasilmkd, could you please review? Is there a reason why the respective apply method taking the end year was added non public?

@vasilmkd
Copy link
Contributor

vasilmkd commented Oct 24, 2022

Hi, in my original change that added support for headerEndYear, I didn't want to impose a new public API on users.

I think you should be free to make it public.

I'm curious to see where the sbt-github build broke, the change #282 should have been source and binary compatible.

@alejandrohdezma
Copy link
Contributor Author

Hey @vasilmkd the reason was that in sbt-github I was already sending the year range it extracted from GitHub so it got into headers. And now it is failing because "2019-2022".toInt fails. I quickly solved it by inlining the whole implementation for LicensdeDetection.apply. But I would prefer to use the actual method.

@vasilmkd
Copy link
Contributor

Cool, thanks for explaining! I believe the method can be safely exposed publicly.

@hseeberger
Copy link
Member

Thanks, guys!

@hseeberger hseeberger merged commit fc2b640 into sbt:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants