Support files without extensions / hidden files #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurz
commented
Oct 18, 2022
| // Files named exactly "more.routes" | ||
| headerMappings := headerMappings.value + (HeaderFileType("routes", None, "more") -> HeaderCommentStyle.cStyleBlockComment) | ||
| // Hidden files named exactly ".routes" | ||
| headerMappings := headerMappings.value + (HeaderFileType("", None, ".routes") -> HeaderCommentStyle.cppStyleLineComment) |
Member
Author
There was a problem hiding this comment.
I think these three lines explain what this whole pull request is all about.
Member
Author
|
@hseeberger Can you take a look? This pull request is fully compatible with previous releases (see the first commit I added) and we would need that feature in the Play Framework. Thanks! |
Member
|
Looking good. Thanks a lot! |
Member
Author
|
@hseeberger Can you please also cut a new release? Thanks! |
Member
Author
|
Thanks for the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First I push a commit to update the current simple scripted test to see if my coming changes will not break backwards compatibility.
Update: That first commit passed the tests 👍
Now I pushed the real "fix" and tests for it.