[2.0.x] bport: Unresolved dependency error for Coursier#8961
Merged
[2.0.x] bport: Unresolved dependency error for Coursier#8961
Conversation
Fixes unresolved dependency path reporting for Coursier (`ResolveException.failedPaths`) and adds a stable scripted regression. This PR addresses 5168 by reconstructing unresolved dependency caller chains from the Coursier resolution graph and attaching them to `ResolveException.failedPaths`. That allows unresolved warnings to show the full path from the missing module up to the root project. It also adds and stabilizes `lm-coursier/unresolved-path` scripted coverage by: - using a local test Maven repo fixture (no flaky remote test dependency) - checking update stream output via an sbt task (`checkLog`) instead of shell `grep` - asserting the unresolved path includes missing module, transitive caller, and root project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #8869 to 2.0.x branch.
Fixes unresolved dependency path reporting for Coursier (ResolveException.failedPaths) and adds a stable scripted regression.
This PR addresses 5168 by reconstructing unresolved dependency caller chains from the Coursier resolution graph and attaching them to
ResolveException.failedPaths. That allows unresolved warnings to show the full path from the missing module up to the root project.It also adds and stabilizes
lm-coursier/unresolved-pathscripted coverage by:checkLog) instead of shellgrep