Skip to content

[2.x] fix: Use new constructor for CantDownloadModule#8905

Merged
eed3si9n merged 1 commit intosbt:developfrom
majk-p:fix/lmcoursier-CantDownloadModule-deprecation
Mar 14, 2026
Merged

[2.x] fix: Use new constructor for CantDownloadModule#8905
eed3si9n merged 1 commit intosbt:developfrom
majk-p:fix/lmcoursier-CantDownloadModule-deprecation

Conversation

@majk-p
Copy link
Copy Markdown
Contributor

@majk-p majk-p commented Mar 14, 2026 •
edited
Loading

This pr fixes the develop build that fails due to a warning in: https://github.com/sbt/sbt/actions/runs/23082287765/job/67053531187#step:18:204

[warn] -- Deprecation Warning: /home/runner/work/sbt/sbt/lm-coursier/src/test/scala/lmcoursier/internal/ResolutionRunSpec.scala:11:8 
[warn] 11 |    new CantDownloadModule(
[warn]    |        ^^^^^^^^^^^^^^^^^^
[warn]    |constructor CantDownloadModule in class CantDownloadModule is deprecated since 2.1.25: Use the override accepting a VersionConstraint instead

Issue introduced in #8903

@majk-p
Copy link
Copy Markdown
Contributor Author

majk-p commented Mar 14, 2026

@eed3si9n wdyt about enabling fatal warnings on PRs as well? it would help picking the issue earlier

@eed3si9n
Copy link
Copy Markdown
Member

eed3si9n commented Mar 14, 2026

I'm confused as to why this got through the CI in the first place. Thanks for following up!

@eed3si9n eed3si9n merged commit 3f9bafc into sbt:develop Mar 14, 2026
15 checks passed
eed3si9n pushed a commit to eed3si9n/sbt that referenced this pull request Mar 23, 2026
@majk-p @eed3si9n
[2.x] fix: use new constructor for CantDownloadModule (sbt#8905)
972cc30
@eed3si9n eed3si9n mentioned this pull request Mar 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@majk-p @eed3si9n