Skip to content

[1.x] deps: Update lm-coursier-shaded 2.1.12#8902

Merged
eed3si9n merged 2 commits intosbt:1.12.xfrom
majk-p:update/lm-coursier-shaded
Mar 14, 2026
Merged

[1.x] deps: Update lm-coursier-shaded 2.1.12#8902
eed3si9n merged 2 commits intosbt:1.12.xfrom
majk-p:update/lm-coursier-shaded

Conversation

@majk-p
Copy link
Copy Markdown
Contributor

@majk-p majk-p commented Mar 13, 2026

2.1.12 introduces retries for 5xx http errors per coursier/sbt-coursier#601

@eed3si9n
Copy link
Copy Markdown
Member

Thanks for the contribution. I have a sbt 2.x version of bump PR here (#8381) and you might need to apply the workaround for coursier/coursier#3525 in sbt-app/src/sbt-test/dependency-management/scala-version-check-exempt/build.sbt from the PR.

Comment on lines +7 to +15
// This is a workaround for https://github.com/coursier/coursier/issues/3525, ported backported from https://github.com/sbt/sbt/pull/8381/changes#diff-bb1add3538eec3272df81b1f5bef249d096aa240d5408a4ceff8917557f5142fR15
// [info] [error] lmcoursier.internal.shaded.coursier.params.rule.SameVersion$CantForceSameVersion:
// Can't force version 2.11.12 for modules org.scala-lang:scala-compiler, org.scala-lang:scala-reflect, org.scala-lang:scala-library
// ....
// [info] [error] Caused by: lmcoursier.internal.shaded.coursier.params.rule.SameVersion$SameVersionConflict:
// Unsatisfied rule SameVersion(HashSet(ModuleMatcher(org.scala-lang:scala-compiler), ModuleMatcher(org.scala-lang:scalap),
// ModuleMatcher(org.scala-lang:scala-actors), ModuleMatcher(org.scala-lang:scala-reflect), ModuleMatcher(org.scala-lang:scala-library))):
// Found versions 2.11.0, 2.11.12 for org.scala-lang:scala-actors, org.scala-lang:scala-compiler, org.scala-lang:scala-library, org.scala-lang:scala-reflect
libraryDependencies += "org.scala-lang" % "scala-actors" % "2.11.12"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majk-p
Copy link
Copy Markdown
Contributor Author

majk-p commented Mar 14, 2026

Thanks @eed3si9n! Applied the fix, scripted seems green locally

Copy link
Copy Markdown
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 132e0c6 into sbt:1.12.x Mar 14, 2026
10 checks passed
eed3si9n added a commit to eed3si9n/sbt that referenced this pull request Mar 18, 2026
@eed3si9n
Copy link
Copy Markdown
Member

FYI - some builds are hanging on sbt 1.12.6 (#8917), so I'm going to revert this change in #8918

eed3si9n added a commit that referenced this pull request Mar 18, 2026
Revert "[1.x] deps: Update lm-coursier-shaded 2.1.12 (#8902)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants