[2.x] fix: Unresolved dependency error for Coursier#8869
Merged
eed3si9n merged 3 commits intosbt:developfrom Mar 3, 2026
Merged
[2.x] fix: Unresolved dependency error for Coursier#8869eed3si9n merged 3 commits intosbt:developfrom
eed3si9n merged 3 commits intosbt:developfrom
Conversation
Contributor
Author
|
@eed3si9n Ready for review. |
eed3si9n
approved these changes
Mar 3, 2026
Member
eed3si9n
left a comment
eed3si9n
left a comment
There was a problem hiding this comment.
Nice! Thanks for the contribution.
eed3si9n
changed the title
eed3si9n
pushed a commit
to eed3si9n/sbt
that referenced
this pull request
Mar 23, 2026
Fixes unresolved dependency path reporting for Coursier (`ResolveException.failedPaths`) and adds a stable scripted regression. This PR addresses 5168 by reconstructing unresolved dependency caller chains from the Coursier resolution graph and attaching them to `ResolveException.failedPaths`. That allows unresolved warnings to show the full path from the missing module up to the root project. It also adds and stabilizes `lm-coursier/unresolved-path` scripted coverage by: - using a local test Maven repo fixture (no flaky remote test dependency) - checking update stream output via an sbt task (`checkLog`) instead of shell `grep` - asserting the unresolved path includes missing module, transitive caller, and root project
eed3si9n
added a commit
that referenced
this pull request
Mar 23, 2026
Fixes unresolved dependency path reporting for Coursier (`ResolveException.failedPaths`) and adds a stable scripted regression. This PR addresses 5168 by reconstructing unresolved dependency caller chains from the Coursier resolution graph and attaching them to `ResolveException.failedPaths`. That allows unresolved warnings to show the full path from the missing module up to the root project. It also adds and stabilizes `lm-coursier/unresolved-path` scripted coverage by: - using a local test Maven repo fixture (no flaky remote test dependency) - checking update stream output via an sbt task (`checkLog`) instead of shell `grep` - asserting the unresolved path includes missing module, transitive caller, and root project Co-authored-by: bitloi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes unresolved dependency path reporting for Coursier (
ResolveException.failedPaths) and adds a stable scripted regression.This PR addresses
#5168by reconstructing unresolved dependency caller chains from the Coursier resolution graph and attaching them toResolveException.failedPaths. That allows unresolved warnings to show the full path from the missing module up to the root project.It also adds and stabilizes
lm-coursier/unresolved-pathscripted coverage by:checkLog) instead of shellgrepRelated Issues
Fixes #5168
Reproduction / Verification
./sbt "lmCoursier/test"./sbt "scripted lm-coursier/unresolved-path"com.example.repo:missing:1.0com.example.repo:a:1.0com.example:...(root project)Testing
lm-coursier/src/test/scala/lmcoursier/ResolutionSpec.scalasbt-app/src/sbt-test/lm-coursier/unresolved-path/build.sbtsbt-app/src/sbt-test/lm-coursier/unresolved-path/testsbt-app/src/sbt-test/lm-coursier/unresolved-path/repo/com/example/repo/a/1.0/a-1.0.pomsbt-app/src/sbt-test/lm-coursier/unresolved-path/repo/com/example/repo/a/1.0/a-1.0.jar./sbt "lmCoursier/test"./sbt "scripted lm-coursier/unresolved-path"Checklist