[2.x] fix: Undefined per-project settings order#8862
Merged
eed3si9n merged 1 commit intosbt:developfrom Mar 3, 2026
Merged
Conversation
Member
|
I'll get back to the actual review when I have time to read the code a bit, but thanks for working on this issue! |
eed3si9n
pushed a commit
to eed3si9n/sbt
that referenced
this pull request
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, as
build.definedis a map with undefined order,projectSettingscould have a default "empty" initializer go after a cross-project appender. Whether it would work or not depended on this internal map order randomness, so, for example (see an added scripted test), defining thelazy val baz = projectwould cause an emptysourceGenerators, but defining thelazy val ewikqelkqweqopweo = projectwould work as intended.This fix eliminates this randomness, so cross-project settings always go after own-scoped or global settings. Should not affect anything, as previously order was undefined in such cases.
Closes #7173