[2.0.x] fix: Print server stderr on startup failure (#8816)#8857
Merged
[2.0.x] fix: Print server stderr on startup failure (#8816)#8857
Conversation
**Problem** When the sbt server fails to start (e.g. wrong JDK version), the client only shows "failed to connect to server" hiding the actual error. The server stderr is redirected to /dev/null to prevent Linux pipe buffer deadlocks (sbt#8442), so diagnostic output is lost. **Solution** Redirect server stderr to a temp file instead of /dev/null. When the server fails to start (portfile never appears), read and print the temp file contents before throwing ServerFailedException. The temp file is cleaned up eagerly on both success and failure paths. Fixes sbt#8812
eed3si9n
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #8816
Problem
When the sbt server fails to start (e.g. wrong JDK version), the client only shows "failed to connect to server" hiding the actual error. The server stderr is redirected to /dev/null to prevent Linux pipe buffer deadlocks (#8442), so diagnostic output is lost.
Solution
Redirect server stderr to a temp file instead of /dev/null. When the server fails to start (portfile never appears), read and print the temp file contents before throwing ServerFailedException. The temp file is cleaned up eagerly on both success and failure paths.
Fixes #8812