[1.x] bport: Fixes double quotes handling in fork mode (#8765)#8845
Merged
eed3si9n merged 1 commit intosbt:1.12.xfrom Mar 1, 2026
Merged
[1.x] bport: Fixes double quotes handling in fork mode (#8765)#8845eed3si9n merged 1 commit intosbt:1.12.xfrom
eed3si9n merged 1 commit intosbt:1.12.xfrom
Conversation
When using the arguments file (`@argsfile`) mechanism for forked runs,
double quotes inside arguments were not escaped, causing the JVM's
argument file parser to strip them. For example, passing `{"a":1}` as
an argument would result in `{a:1}`.
Escape `"` as `\"` in `createArgumentsFile`, matching the existing
backslash escaping, so the JVM correctly round-trips quoted arguments.
Fixes sbt#7129
Co-Authored-By: Claude Opus 4.6 <[email protected]>
eed3si9n
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #8765
When using the arguments file (
@argsfile) mechanism for forked runs, double quotes inside arguments were not escaped, causing the JVM's argument file parser to strip them. For example, passing{"a":1}as an argument would result in{a:1}.Escape
"as\"increateArgumentsFile, matching the existing backslash escaping, so the JVM correctly round-trips quoted arguments.Fixes #7129