[2.x] fix: IgnoreSourceChanges now works#8820
Merged
eed3si9n merged 2 commits intosbt:developfrom Feb 28, 2026
Merged
Conversation
seroperson
force-pushed
the
i6773-on-changed-build-source
branch
3 times, most recently
from
abdc533 to
a0c9c53
Compare
seroperson
force-pushed
the
i6773-on-changed-build-source
branch
from
a0c9c53 to
19a32d9
Compare
eed3si9n
requested changes
Feb 27, 2026
eed3si9n
reviewed
Feb 27, 2026
Comment on lines
+151
to
+152
| } else if (onChanges == IgnoreSourceChanges) { | ||
| false |
eed3si9n
pushed a commit
to eed3si9n/sbt
that referenced
this pull request
Mar 1, 2026
eed3si9n
added a commit
that referenced
this pull request
Mar 1, 2026
Closes #6773 Co-authored-by: Daniil Sivak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
onChangedBuildSource := IgnoreSourceChangeswas literally (mostly) ignored.IgnoreSourceChangesis set.*.sbtfiles ifonChangedBuildSourceset toIgnoreSourceChanges. There is already the same check inCheckBuildSources.buildSourceFileInputslogic, which also seems like covers that glob too, so I even unsure whether this append is necessary at all.Closes #6773