[2.x] fix: Fixes sbt runner script' sbtn detection#8810
Merged
eed3si9n merged 1 commit intosbt:developfrom Feb 25, 2026
Merged
Conversation
fireXtract
changed the title
** Problem ** sbtn-x86_64-apple-darwin doesn't exist anymore ** Solution ** point to universal binary instead tested on 1.10.1 and 1.12.3 via vlog statements in acquire_sbtn no longer appearing after the change confirming that detectNativeClient set the correct value
fireXtract
force-pushed
the
universal-sbtn
branch
from
408c8f9 to
eb9169e
Compare
eed3si9n
changed the title
eed3si9n
pushed a commit
to eed3si9n/sbt
that referenced
this pull request
Mar 1, 2026
** Problem ** sbtn-x86_64-apple-darwin doesn't exist anymore ** Solution ** point to universal binary instead
eed3si9n
pushed a commit
to eed3si9n/sbt
that referenced
this pull request
Mar 1, 2026
** Problem ** sbtn-x86_64-apple-darwin doesn't exist anymore ** Solution ** point to universal binary instead
eed3si9n
added a commit
that referenced
this pull request
Mar 1, 2026
** Problem ** sbtn-x86_64-apple-darwin doesn't exist anymore ** Solution ** point to universal binary instead Co-authored-by: fireXtract <[email protected]>
eed3si9n
added a commit
that referenced
this pull request
Mar 1, 2026
** Problem ** sbtn-x86_64-apple-darwin doesn't exist anymore ** Solution ** point to universal binary instead Co-authored-by: fireXtract <[email protected]>
eed3si9n
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sbtn-x86_64-apple-darwindoesn't exist anymore.While the existing solution does work, it seemed worth tidying up while I had it in mind.
I tested this fix on 1.10.1 and 1.12.3, and it prevents entering the acquire_sbtn function when detectNativeBinary detects the binary already exists.