[2.x] fix: Prefer direct key selection over aggregate-only fallback#8775
Merged
eed3si9n merged 1 commit intosbt:developfrom Feb 21, 2026
Merged
Conversation
**Problem** `testFull` can select an aggregate-only key before a directly defined root key. In issue sbt#8772 this causes root project tests to be skipped, so a failing root test can pass unexpectedly. **Solution** Prefer directly defined keys in `Act.select`, and only fall back to aggregate-only candidates when no direct key exists. Add scripted regression test `tests/i8772-root-project-testfull` and keep `project/extra-projects-key-aggregate` behavior intact.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
2.0.0-RC9,testFullcan resolve to an aggregate-only candidate before a directly defined key.For a root project, this can run only aggregated child tests and skip root tests, so failing root tests may pass unexpectedly.
Solution
Update
Act.selectto prefer directly defined keys in settings data and only use aggregate-only candidates as a fallback.Add a scripted regression test at
tests/i8772-root-project-testfull, while preserving aggregate fallback behavior covered byproject/extra-projects-key-aggregate.Verification
2.0.0-RC9and confirmed expected behavior on2.0.0-RC8../sbt "scripted tests/i8772-root-project-testfull"./sbt "scripted project/extra-projects-key-aggregate"I manually reviewed all changes and verified behavior locally.
Closes #8772