[2.x] feat: client-side run env inheritance#8752
Merged
eed3si9n merged 2 commits intosbt:developfrom Feb 17, 2026
Merged
Conversation
Contributor
Author
|
added validation evidence for this branch:\n\nran in JDK 17 container:\ndocker run --rm -v "/Users/Avantika/Documents/New project":/work -w /work eclipse-temurin:17-jdk bash -lc './sbt ";project commandProj;testOnly sbt.internal.util.RunHandlerTest"'\n\nresult:\n- RunHandlerTest passed\n- test: mergedEnvVars includes current process environment and applies explicit overrides |
Contributor
Author
|
Scala CLA has been signed for aviu16 and I pushed a no-op commit to retrigger checks.\n\nCurrent new runs are in action_required state, likely awaiting maintainer approval to run workflows for fork PRs. |
eed3si9n
changed the title
|
I've been waiting a long time for this ❤️ Can't wait to test it out... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7012.
When
sbtn runis executed through client jobs, the run env currently only uses explicit task env vars. This can keep stale process-level values around across invocations.This change merges the current client process environment (
sys.env) with explicit overrides, so each invocation reflects the shell env it was started with.Changes:
sys.envwith job env overrides inRunHandler.jvmRunNetworkClient