[2.x] Respect scalaOrganization in compiler bridge resolution#8732
Merged
eed3si9n merged 1 commit intosbt:developfrom Feb 21, 2026
Merged
[2.x] Respect scalaOrganization in compiler bridge resolution#8732eed3si9n merged 1 commit intosbt:developfrom
scalaOrganization in compiler bridge resolution#8732eed3si9n merged 1 commit intosbt:developfrom
Conversation
tanishiking
force-pushed
the
custom-scala-org
branch
from
791c01e to
e31df21
Compare
Member
Relying on external repo is ok for scripted tests (we already have many of them). If it starts failing we'll just disable it, but it would be good to have an integration test to prove out an end-to-end scenario. |
eed3si9n
changed the title
scalaOrganization in compiler bridge resolutionscalaOrganization in compiler bridge resolution
Contributor
Author
|
Thanks, added a scripted tests to verify |
Member
Welcome back, and hope you're feeling better. |
Member
|
Mima is failing but it's internal class so feel free to add excludes: exclude[DirectMissingMethodProblem]("sbt.internal.inc.ZincLmUtil.*"), |
**Problem** `scalaOrganization` was ignored during compiler bridge resolution because `ZincLmUtil.getDefaultBridgeModule` hard-coded `ScalaArtifacts.Organization` (`org.scala-lang`). **Solution** Add a `scalaOrganization` parameter to `ZincLmUtil` methods, and passing `scalaOrganization` value to those methods. Generated-by: Claude Opus 4.6
tanishiking
force-pushed
the
custom-scala-org
branch
from
4560b5a to
72938a9
Compare
Contributor
Author
|
Thanks! now CI passed 👍 |
eed3si9n
pushed a commit
to eed3si9n/sbt
that referenced
this pull request
Feb 23, 2026
…8732) **Problem** `scalaOrganization` was ignored during compiler bridge resolution because `ZincLmUtil.getDefaultBridgeModule` hard-coded `ScalaArtifacts.Organization` (`org.scala-lang`). **Solution** Add a `scalaOrganization` parameter to `ZincLmUtil` methods, and passing `scalaOrganization` value to those methods. Generated-by: Claude Opus 4.6
eed3si9n
added a commit
that referenced
this pull request
Feb 23, 2026
… (#8799) **Problem** `scalaOrganization` was ignored during compiler bridge resolution because `ZincLmUtil.getDefaultBridgeModule` hard-coded `ScalaArtifacts.Organization` (`org.scala-lang`). **Solution** Add a `scalaOrganization` parameter to `ZincLmUtil` methods, and passing `scalaOrganization` value to those methods. Generated-by: Claude Opus 4.6 Co-authored-by: Rikito Taniguchi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8731
Problem
scalaOrganizationwas ignored during compiler bridge resolution becauseZincLmUtil.getDefaultBridgeModulehard-codedScalaArtifacts.Organization(org.scala-lang).Solution
Add a
scalaOrganizationparameter toZincLmUtilmethods, and passingscalaOrganizationvalue to those methods.I'm wondering how can we test this change, we can write scripted tests that resolves
io.github.scala-wasmrepo, but relying on external repositories might be fragile?Generated-by: Claude Opus 4.6