[2.x] fix: restore CLI precedence over .sbtopts (#8685)#8695
Merged
eed3si9n merged 3 commits intosbt:developfrom Feb 5, 2026
Merged
[2.x] fix: restore CLI precedence over .sbtopts (#8685)#8695eed3si9n merged 3 commits intosbt:developfrom
eed3si9n merged 3 commits intosbt:developfrom
Conversation
Contributor
Author
|
@eed3si9n could you plz review my PR? |
eed3si9n
approved these changes
Feb 5, 2026
Member
eed3si9n
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Contributor
|
@it-education-md Thanks! I had this on my list to look into this weekend and you completely beat me to it :) |
Contributor
|
@eed3si9n mind if we backport to 1.12.x ? |
Contributor
|
I spent some additional time studying the fix and the workflow, and I really do like this solution. |
Member
|
Yea, would you like to send a PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8685
1. Summary
Restore command-line JVM argument precedence over
.sbtoptsin the launcher script and add aregression test.
2. Problem
According to the issue,
.sbtoptsentries are appended afterCLI args in sbt 1.12.x, so
.sbtoptsJVM memory settings (e.g.,-Xmx2g) override CLI--mem,causing invalid JVM settings.
3. Reproduction
Step 1. Create
tmp/.sbtopts:Step 2. Run:
Logs (Current behavior)
4. Solution
Load sbtopts file options (dist/machine/project) into a list and prepend them to the argument
list so CLI args remain last and win. Preserve existing file priority: project > machine > dist.
5. Tests
Run with .sbtopts
Logs (with fix)
RunnerScriptTest
Scala Format Check
./sbt scalafmtAll(passed)