[2.x] feat: Implement ivyless publishLocal#8634
Conversation
|
@eed3si9n Could you please review my pr? |
|
I don't have time to do a detailed review, but pretty excited about this one. Thanks for the contribution! |
Feel free to do it when you get a chance |
| // Helper to compute hash using MessageDigest | ||
| def computeHash(file: File, algorithm: String): String = { |
There was a problem hiding this comment.
sbt.util.Digest(Digest.Sha1, path) can be used from https://github.com/sbt/sbt/blob/develop/util-cache/src/main/scala/sbt/util/Digest.scala, although Digest probably need a method added to get just the hash string.
|
@eed3si9n I've fixed all. Would you mind taking a second look? |
eed3si9n
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround. lgtm!
Summary
Implements ivyless
publishLocaltask as part of the effort to remove Ivy dependency (#7639).Fixes #8631
Changes:
useIvysetting key (defaults totrue)ivylessPublishLocalImplhelper that publishes without IvypublishLocalto use ivyless publisher whenuseIvy := falselmcoursier.IvyXmldependency-management/ivyless-publish-localFiles changed:
main/src/main/scala/sbt/Keys.scala- new setting keymain/src/main/scala/sbt/Defaults.scala- implementationsbt-app/src/sbt-test/dependency-management/ivyless-publish-local/- scripted testTest plan
mainProj/compilepassesmainProj/testpasses (91 tests)scalafmtCheckAllpassesmimaReportBinaryIssuespassesscripted dependency-management/ivyless-publish-localpassespackageDoc / publishArtifact := false)