[2.x] feat: Support forked console#8604
Merged
eed3si9n merged 1 commit intosbt:developfrom Jan 25, 2026
Merged
Conversation
93c3009 to
341777b
Compare
Contributor
Author
|
@eed3si9n Could you please review my pr? The failed CI check is flaky one, isn't related to my change |
Member
You got the arrows key to work? |
Contributor
Author
Yeah, they work well |
Contributor
Author
Screen.Recording.2026-01-21.at.4.03.33.PM.mov |
Member
|
Nice! |
Contributor
Author
|
@eed3si9n Looks like all CI checks have passed |
Member
|
Yea, a slight conundrum is that I started making some improvements on the common parts between console and compile #8584 (like using URI instead of String), so if I merge this, I'd need to follow up with some changes afterwards. And I can't land the forked compile one because all the tests haven't passed. I can review this PR soon, if you're ok with some of the changes in this PR getting overwritten soon. The repl specific parts should mostly stay intact. |
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1918
Summary
Implements
fork in console := trueas requested in #1918.When enabled, the Scala REPL runs in a separate JVM, which allows:
java.library.pathfor native librariesImplementation
ConsoleMainas the entry point for the forked processProcessBuilder.inheritIO()to properly inherit terminal streams (critical for arrow key support)javaOptionsandjavaHomeare passed throughUsage
Test plan