[2.x] feat: Add setup-java action support in CrossJava#8574
Merged
eed3si9n merged 2 commits intosbt:developfrom Jan 20, 2026
Merged
[2.x] feat: Add setup-java action support in CrossJava#8574eed3si9n merged 2 commits intosbt:developfrom
eed3si9n merged 2 commits intosbt:developfrom
Conversation
eed3si9n
reviewed
Jan 19, 2026
main/src/main/scala/sbt/internal/inc/CompileAnalysisFormats.scala
Outdated
Show resolved
Hide resolved
Add SetupJavaDiscoverConfig to detect JDKs installed by GitHub's setup-java action at paths like: - /opt/hostedtoolcache/Java_Zulu_jdk/25.0.1-8/x64 (Linux) - C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\11.0.29-7\x64 (Windows) These JDKs are now available in fullJavaHomes as [email protected], [email protected], etc. Supported vendors: Zulu, Temurin, Adopt, Corretto, Liberica, Microsoft, Semeru. Temurin-Hotspot and Adopt are normalized to temurin. Fixes sbt#8582
e99493f to
e9e071a
Compare
eed3si9n
requested changes
Jan 20, 2026
Member
eed3si9n
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I think test needs a bit more work, but overall going the right direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SetupJavaDiscoverConfig to detect JDKs installed by GitHub's setup-java action at paths like:
These JDKs are now available in fullJavaHomes as [email protected], [email protected], etc.
Supported vendors: Zulu, Temurin, Adopt, Corretto, Liberica, Microsoft, Semeru. Temurin-Hotspot and Adopt are normalized to
temurin.
Fixes #8582