[2.x] fix: Handle -X JVM options on command line#8566
Merged
eed3si9n merged 2 commits intosbt:developfrom Jan 17, 2026
Merged
Conversation
This is a Gittensor contribution. Previously, passing JVM options like -Xmx1G directly on the command line would result in an error: sbt -v -Xmx1G [error] Expected ';' [error] -Xmx1G [error] ^ This was because -X options were being passed to sbt as commands instead of being recognized as JVM arguments. Changes: - Added handling for -X options in sbt.bat to pass them to the JVM - Updated help text to document this feature - Added integration tests for the new functionality
eed3si9n
approved these changes
Jan 17, 2026
Member
eed3si9n
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
eed3si9n
pushed a commit
to eed3si9n/sbt
that referenced
this pull request
Jan 17, 2026
Previously, passing JVM options like -Xmx1G directly on the command line would result in an error: sbt -v -Xmx1G [error] Expected ';' [error] -Xmx1G [error] ^ This was because -X options were being passed to sbt as commands instead of being recognized as JVM arguments. Changes: - Added handling for -X options in sbt.bat to pass them to the JVM - Updated help text to document this feature - Added integration tests for the new functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5742
Previously, passing JVM options like
-Xmx1Gdirectly on the command line would result in an error:sbt -v -Xmx1G [error] Expected ';' [error] -Xmx1G [error] ^This was because
-Xoptions were being passed to sbt as commands instead of being recognized as JVM arguments.Changes
-Xoptions insbt.batto pass them to the JVM via:addJavaTesting
With this fix:
The
-Xmx1Gis now correctly passed to the JVM.This is a Gittensor contribution.
gittensor:user:GlobalStar117