[2.x] fix: Prevent sbt test from hanging when forked process crashes#8536
Merged
eed3si9n merged 1 commit intosbt:developfrom Jan 15, 2026
Merged
Conversation
When a forked test process crashes (e.g., due to UnsupportedClassVersionError), sbt would hang forever waiting for test results. This happened because notifyExit only completed the promise with success, regardless of the exit code. This fix checks the exit code and fails the promise if the process exited with a non-zero code, allowing sbt to properly report the failure and exit. Fixes sbt#7429
Contributor
Author
|
@eed3si9n please have a look at the PR and let me know the result |
eed3si9n
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a forked test process crashes (e.g., due to UnsupportedClassVersionError), sbt would hang forever waiting for test results. This happened because notifyExit only completed the promise with success, regardless of the exit code.
This fix checks the exit code and fails the promise if the process exited with a non-zero code, allowing sbt to properly report the failure and exit.
Fixes #7429
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=94194147