[2.x] fix: Skip checksums for PGP signature files (.asc)#8535
Merged
eed3si9n merged 2 commits intosbt:developfrom Jan 15, 2026
Merged
[2.x] fix: Skip checksums for PGP signature files (.asc)#8535eed3si9n merged 2 commits intosbt:developfrom
eed3si9n merged 2 commits intosbt:developfrom
Conversation
Contributor
Author
|
@eed3si9n Please I'd love you to take a look at this PR |
eed3si9n
changed the title
Member
|
@Dairus01 Before I land, would you like to change the pull request description to say |
Dairus01
changed the title
Contributor
Author
Done |
Member
|
I meant
I'll just do it myself. |
eed3si9n
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
publishSigned(via sbt-pgp), sbt creates checksum files (e.g.,.pom.asc.sha1) for PGP signature files (.asc). This violates Maven norms, where checksums should only be generated for raw artifacts like JARs and POMs, not for signatures.Fixes #8134
Solution
Modified the checksum generation logic in
ChecksumFriendlyURLResolver.put(inlm-ivy/src/main/scala/sbt/internal/librarymanagement/ConvertResolver.scala) to skip generating checksums for artifacts whose names end with.asc.The change wraps the checksum loop in:
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=201190161