[2.x] fix: Propagate SBT_OPTS to BSP config#8531
Merged
eed3si9n merged 1 commit intosbt:developfrom Jan 14, 2026
Merged
Conversation
Contributor
Author
|
@eed3si9n can you please have a look at the PR and let me know the feedback? |
Member
|
Not sure why AppVeyor is showing up here. |
Fixes sbt#7469 When running 'sbt bspConfig', the generated .bsp/sbt.json now includes JVM options from the SBT_OPTS environment variable. This ensures that options like -Dsbt.boot.directory are propagated to the BSP server. The parseSbtOpts method extracts -D, -X, and -J prefixed options from SBT_OPTS and includes them in the BSP connection argv.
MkDev11
force-pushed
the
fix/bsp-config-sbt-opts-7469
branch
from
b1cce73 to
6c984fa
Compare
Contributor
Author
Sorry for the mistake, just fixed it |
eed3si9n
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate SBT_OPTS environment variable to BSP connection file
Description
When using sbt with IDEs through BSP (Build Server Protocol), the JVM options set in
SBT_OPTSweren't being passed to the BSP server. This meant things like custom memory settings or system properties would work in the terminal but not when using BSP.This PR fixes that by reading
SBT_OPTSwhen generating the BSP connection file and including the relevant JVM options (-D,-X,-Jprefixed args) in the server startup command.Changes
SBT_OPTSenvironment variable inBuildServerConnection.writeConnectionFile-Jprefix from options (same behavior as the sbt launcher)Testing
parseSbtOptsmethod covering various option formatsFixes #7469
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=94194147