[2.x] fix: Fix watchTriggers to control what triggers#8525
Merged
eed3si9n merged 2 commits intosbt:developfrom Jan 14, 2026
Merged
[2.x] fix: Fix watchTriggers to control what triggers#8525eed3si9n merged 2 commits intosbt:developfrom
eed3si9n merged 2 commits intosbt:developfrom
Conversation
…nputs When watchTriggers is explicitly set (non-empty), use only watchTriggers instead of combining them with fileInputs. This allows users to control what triggers the watch by setting watchTriggers. Fixes sbt#7130
eed3si9n
changed the title
Contributor
Author
|
@eed3si9n Thank you for updating pr title, Could you please check failing check? |
Contributor
Author
|
maybe, need to restart queue? |
Contributor
Author
|
@eed3si9n Thank you for restarting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
watchTriggersdoesn't work as expected - it's always combined withfileInputs, so even when set to watch specific files, other files (like resources) still trigger builds.Solution
When
watchTriggersis explicitly set (non-empty), use onlywatchTriggersinstead of combining them withfileInputs. This allows users to control what triggers the watch.Changes
WatchTransitiveDependencies.scalato check ifwatchTriggersis set before combining withfileInputstriggerGlobsis non-empty: use onlytriggerGlobs(plus legacy sources)triggerGlobsis empty: use existing behavior (combiningfileInputsandwatchTriggers)Fixes #7130
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=158349177