Merged
Conversation
eed3si9n
reviewed
Jan 13, 2026
Member
eed3si9n
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Do you have before / after comparison even if it's a manual test?
Contributor
Author
yes, I ran simple test
|
Member
|
Could you sign the CLA and let me know plz, and I'll rerun the check. |
Contributor
Author
I've signed, can you plz rerun it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7971
Problem
When running sbt with
--warnor--errorlog levels, logs created from commands usingstate.logwere not displayed on the console. This affected:MessageOnlyExceptionthrown in commandsExample:
# Expected warnings and errors to show, but console was empty $ sbt --warn logCommand $ sbt --error logCommandRoot Cause
In
LogManager.setGlobalLogLevel, when updating the global log level:backed(file) appender was re-added with the new levelThis meant logs were only written to the backing file (
target/global-logging/*.log), not displayed on the console.Solution
Modified
setGlobalLogLevelto preserve the console appender when changing log levels:Now both the console and file appenders are properly configured with the new log level.
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=147358252