[2.x] fix: Fix StackOverflowError when reporting self-referencing exceptions#8508
Merged
eed3si9n merged 1 commit intosbt:developfrom Jan 13, 2026
Merged
Conversation
Add circular reference detection to StackTrace.trimmedLines using an IdentityHashMap-backed Set, similar to how the JDK handles this in Throwable.printStackTrace(). When a circular reference is detected, the method now appends a [CIRCULAR REFERENCE: ...] message instead of recursing infinitely. Fixes sbt#7509
Contributor
Author
|
@eed3si9n all checks passed, please review the PR and let me know your feedback. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix StackOverflowError when reporting self-referencing exceptions
Problem
When an exception has a circular reference in its cause chain (e.g.,
exception.getCause() == exception), sbt throws aStackOverflowErrorwhile trying to report the exception. This happens becauseStackTrace.trimmedLinestraverses the cause chain without checking for circular references.This is problematic because some libraries or frameworks may create exceptions with self-referencing causes, and sbt should be resilient to such edge cases.
Solution
This PR adds circular reference detection to
StackTrace.trimmedLinesusing anIdentityHashMap-backedSet, similar to how the JDK handles this inThrowable.printStackTrace().When a circular reference is detected, instead of recursing infinitely, the method now appends a
[CIRCULAR REFERENCE: ...]message to indicate the cycle.Changes
StackTrace.trimmedLinesto track seen exceptions usingIdentityHashMapExample Output
For a self-referencing exception, the output now looks like:
Fixes #7509
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=94194147