[2.x] fix: Use strict matching for scala-library jar detection#8507
Merged
eed3si9n merged 1 commit intosbt:developfrom Jan 13, 2026
Merged
Conversation
Fixes sbt#7511 The previous check used contains("scala-library") which incorrectly matched any jar with that substring anywhere in the filename, causing user libraries named like "my-scala-library-foo" to be misclassified as the Scala standard library and filtered from the classpath. Changed to use exact match (scala-library.jar) or prefix match (scala-library-*) to only match the actual Scala library jars, consistent with how scala-reflect is detected on line 199.
Contributor
Author
|
All passed! please review the changes and approve it. thanks. |
eed3si9n
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Strict matching for scala-library jar detection
Problem
If you name your library something like
my-scala-library-utils, sbt won't be able to find it at compile time. The build fails with cryptic "object not found" errors even though the jar is clearly downloaded and present.This happens because sbt uses
name.contains("scala-library")to detect the Scala standard library jar. Any jar with "scala-library" anywhere in its filename gets misclassified and filtered into a special classloader layer meant only for the actual Scala stdlib.The Fix
Changed from substring matching to strict matching:
This matches the pattern already used for
scala-reflectdetection in the same fileFixes #7511
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=94194147